Skip to content

Fix bug in rate_limiter filter and add more tests #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 7, 2024
Merged

Fix bug in rate_limiter filter and add more tests #237

merged 8 commits into from
Dec 7, 2024

Conversation

christophfroehlich
Copy link
Contributor

@christophfroehlich christophfroehlich commented Nov 20, 2024 •
edited
Loading

I ran in the same issue as was solved with diff_drive_controller already ros-controls/ros2_controllers#252
I added some tests, and furthermore improved the generate_parameter_library parameter declaration file.

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024 •
edited
Loading

Codecov Report

❌ Patch coverage is 97.61905% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.78%. Comparing base (3a3e36e) to head (361dd0c).
⚠️ Report is 126 commits behind head on ros2-master.

Files with missing lines Patch % Lines
test/control_filters/test_rate_limiter.hpp 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@               Coverage Diff               @@
##           ros2-master     #237      +/-   ##
===============================================
+ Coverage        71.05%   74.78%   +3.73%     
===============================================
  Files               20       22       +2     
  Lines             1040     1071      +31     
  Branches            84       85       +1     
===============================================
+ Hits               739      801      +62     
+ Misses             255      222      -33     
- Partials            46       48       +2
Flag Coverage Δ
unittests 74.78% <97.61%> (+3.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
include/control_filters/rate_limiter.hpp 73.07% <100.00%> (+73.07%) ⬆️
include/control_toolbox/rate_limiter.hpp 73.01% <ø> (+4.76%) ⬆️
test/control_filters/test_load_rate_limiter.cpp 100.00% <ø> (ø)
test/control_filters/test_rate_limiter.cpp 100.00% <100.00%> (ø)
test/control_filters/test_rate_limiter.hpp 92.30% <92.30%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich marked this pull request as ready for review November 22, 2024 20:53
saikishor
saikishor reviewed Nov 22, 2024
View reviewed changes
@christophfroehlich christophfroehlich merged commit 93955a8 into ros2-master Dec 7, 2024
23 of 26 checks passed
@christophfroehlich christophfroehlich deleted the test/rate_limiter branch December 7, 2024 08:18
@christophfroehlich christophfroehlich mentioned this pull request Apr 22, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saikishor saikishor saikishor approved these changes

@bmagyar bmagyar Awaiting requested review from bmagyar

@fmauch fmauch Awaiting requested review from fmauch

@homalozoa homalozoa Awaiting requested review from homalozoa

@mamueluth mamueluth Awaiting requested review from mamueluth

@mcbed mcbed Awaiting requested review from mcbed

@peterdavidfagan peterdavidfagan Awaiting requested review from peterdavidfagan

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christophfroehlich @codecov-commenter @saikishor